small improvements #174
Open
small improvements #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
reviewed
Feb 15, 2018
| @@ -150,7 +150,7 @@ path nonsense? Don't worry, you don't. You can just use environment variables in | |||
| singularity exec --app foo foobar.simg env | grep foo | |||
| ``` | |||
|
|
|||
| Let's talk about the output of the above in sections, you will notice some interesting things! First, notice that the app's `bin` has been added to the path, and it's `lib` added to the `LD_LIBRARY_PATH`. This means that anything you drop in either will automatically be added. You don't need to make these folders either, they are created for you. | |||
| Let's talk about the output of the above in sections, you will notice some interesting things! First, notice that the app's `bin` has been added to the path, and its `lib` added to the `LD_LIBRARY_PATH`. This means that anything you drop in either will be automatically added. You don't have to create those folders neither, they'll be created for you. | |||
|
|
|||
There was a problem hiding this comment.
This would be a double negative, "don't have to" plus "neither" would mean you have to create them. I think it should be "you don't have to create those folders either"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.